pipeline architecture and workflow updates #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisparnin
requested changes
Jul 22, 2020
Contributor
chrisparnin
left a comment
chrisparnin
left a comment
There was a problem hiding this comment.
There were a few minor issues, some suggestions, as well as some bugs found.
lib/read/setup.js
Outdated
| /** | ||
| * Setup the env needed for execution | ||
| * @param {String} doc path to steps.yml to inline md file | ||
| * @param {String} html path to html, if doc is steps.yml |
Contributor
There was a problem hiding this comment.
Shouldn't this read, if doc is not specified in steps.yml.
What happens if there is a file in steps.yml and there is a html file provided. Which one gets precedence?
Contributor
There was a problem hiding this comment.
This probably should read:
@param {String} Override html file referenced in steps.yml. Otherwise, if no html file is specified in steps.yml, steps will be executed on provided file.
| case 'command': | ||
| result = await op.run(cell.content, cell.user, cell.persistent); | ||
| break; | ||
| default: |
Contributor
There was a problem hiding this comment.
We need to support all the other operations :)
fix: setting exit code when report=true/false
pipefail=true default in local connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline architecture and workflow updates (WIP).