Skip to content

Fix issues with magic bytes sniffing #920

Merged
marcospb19 merged 8 commits intomainfrom
check-problem
Feb 17, 2026
Merged

Fix issues with magic bytes sniffing #920
marcospb19 merged 8 commits intomainfrom
check-problem

Conversation

@marcospb19
Copy link
Member

@marcospb19 marcospb19 commented Feb 17, 2026

Did a refac for everything wrong with file signature sniffing.

  • Fix sniffed file format overwriting input file
    • Fix asking Y/n question twice (consequence of the above)
  • Remove extensions from output file path when sniffing made Ouch change the format used
  • Fix Ouch not saying what format was sniffed so user decide to proceed
  • Improve error message when sniffing fails
  • Now halt if sniffing disagrees with extension format, sniffed format is likely the right one
    • Error message explains two ways to bypass

@marcospb19 marcospb19 marked this pull request as ready for review February 17, 2026 05:52
@marcospb19 marcospb19 changed the title TODO TITLE check_file_signature fixes Fix issues with magic bytes sniffing Feb 17, 2026
@marcospb19 marcospb19 merged commit 4967053 into main Feb 17, 2026
17 checks passed
@marcospb19 marcospb19 deleted the check-problem branch February 17, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant