fix multiple panics on extraction#950
Merged
Merged
Conversation
Replace .expect() in check_invalid_compression_with_non_archive_format with a fallback when build_archive_file_suggestion returns None. Panic explained in issue ouch-org#942
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few bugs that cause panics or silently lose info
ouch listpanics on a corrupt.bz3file becauseBz3Decoder::newis called with.unwrap().decompress.rsalready uses?for the same call.entry.unwrap()inarchive/tar.rs). Zip and 7z already use?..unwrap_or_default(), so users get files with wrong timestamps and no warning.SUPPORTED_ALIASES:"tzlma"should be"tlzma"(every other place in the codebase usestlzma).ouchpanics at startup if the current directory is unreadable or has been deleted (env::current_dir().expect(...)inmain.rs).--threads 0is handled inconsistently:cli/mod.rstreats it as "auto" butcommands/mod.rsstill passes it to rayon, andbuild_global().unwrap()panics if the thread pool is already initialized.ouch compress input1.txt input2.txt archive.bz3 --yespanics with "output path should contain a compression format" atsrc/check.rs