[feature] Improve tests + CLI tests #69
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis update introduces comprehensive unit tests for several CLI packages, including accounts, panel, and posts, as well as new helpers for CLI test environments using PostgreSQL containers. Existing database table validation tests are improved with dynamic subtests. The GitHub Actions workflow is updated to include CLI test coverage reporting. Changes
Sequence Diagram(s)sequenceDiagram
participant Tester
participant TestHelper
participant DBContainer
participant Handler
Tester->>TestHelper: MakeTestConnection()
TestHelper->>DBContainer: Start PostgreSQL container
DBContainer-->>TestHelper: Provide connection info
TestHelper-->>Tester: Return DB connection
Tester->>Handler: Initialize with DB connection
Tester->>Handler: Execute operation (e.g., CreateAccount)
Handler->>DBContainer: Perform DB operation
DBContainer-->>Handler: Return result
Handler-->>Tester: Return operation result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @gocanto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the isValidTable tests to ensure that all tables defined in the schema are correctly recognized as valid. This change improves the robustness of our table validation logic by dynamically checking against the actual schema tables. Additionally, I've renamed a test function to better reflect its purpose, enhancing test suite readability.
Highlights
- Test Coverage Improvement: The TestIsValidTable function has been updated to dynamically check all tables returned by GetSchemaTables(), ensuring comprehensive validation against the current schema.
- Test Clarity: The test function TestIsValidTableEdgeCases has been renamed to TestIsValidTableNonexistentTables to more accurately describe its purpose of testing invalid or nonexistent table names.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request improves the tests for isValidTable by ensuring all schema tables are checked for validity and by renaming a test for better clarity. The changes are good and increase test coverage. I've added one suggestion to use Go's subtests (t.Run) to improve test failure reporting, which is a common practice in Go testing.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
cli/clitest/helpers.go (1)
33-35: Clarify UUID truncation for master key generation.Truncating
uuid.NewString()[:32]might cut off part of a hyphenated UUID (which is 36 chars). Consider usingstrings.ReplaceAll(uuid.NewString(), "-", "")[:32]to remove hyphens first, or document why truncation is acceptable.-return &env.Environment{App: env.AppEnvironment{MasterKey: uuid.NewString()[:32]}} +return &env.Environment{App: env.AppEnvironment{MasterKey: strings.ReplaceAll(uuid.NewString(), "-", "")[:32]}}cli/posts/handler_test.go (1)
18-27: Consider consolidating duplicatecaptureOutputfunction.This function is identical to the one in
cli/panel/menu_test.go. Consider moving it tocli/clitest/helpers.goto avoid duplication and promote reuse across test files.Move to
cli/clitest/helpers.go:func CaptureOutput(fn func()) string { old := os.Stdout r, w, _ := os.Pipe() os.Stdout = w fn() w.Close() out, _ := io.ReadAll(r) os.Stdout = old return string(out) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (6)
cli/accounts/factory_test.go(1 hunks)cli/accounts/handler_test.go(1 hunks)cli/clitest/helpers.go(1 hunks)cli/panel/menu_test.go(1 hunks)cli/posts/handler_test.go(1 hunks)go.mod(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- go.mod
🧰 Additional context used
🧬 Code Graph Analysis (1)
cli/accounts/factory_test.go (3)
cli/accounts/factory.go (1)
MakeHandler(18-33)cli/accounts/handler.go (1)
CreateAccount(10-30)pkg/auth/handler.go (1)
SetupNewAccount(49-72)
🔇 Additional comments (5)
cli/accounts/factory_test.go (1)
10-26: LGTM! Comprehensive factory test with good coverage.The test properly verifies handler creation, initialization, and end-to-end account creation with database persistence. The use of SQLite for testing provides good isolation.
cli/accounts/handler_test.go (1)
10-37: LGTM! Well-structured handler tests with good coverage.The tests effectively cover both success and error scenarios:
setupAccountHandlerprovides clean test setupTestCreateReadSignaturevalidates the complete account workflowTestCreateAccountInvalidensures proper validation of account namesThe test structure promotes maintainability and follows Go testing best practices.
cli/panel/menu_test.go (2)
13-22: LGTM! Excellent output capture utility.The
captureOutputfunction is well-implemented with proper stdout restoration. This is a clean pattern for testing functions that write to stdout.
24-95: LGTM! Comprehensive test coverage for Menu functionality.The test suite effectively covers:
- Input handling with various scenarios (empty, invalid, valid)
- Output formatting and validation
- Text centering and truncation
- Account name and URL validation
The tests are well-structured, focused, and include appropriate edge cases. Good use of table-driven patterns where applicable.
cli/posts/handler_test.go (1)
29-101: LGTM! Comprehensive posts handler test suite.Excellent test coverage including:
- Complete test environment setup with seeded data
- Success and error scenarios for post handling
- HTTP integration testing with
httptest- Proper database verification of persisted data
The use of realistic test data and comprehensive assertions makes these tests valuable for ensuring handler reliability.
gocanto
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.github/workflows/tests.yml(1 hunks)cli/accounts/factory_test.go(1 hunks)cli/accounts/handler_test.go(1 hunks)cli/clitest/helpers.go(1 hunks)cli/clitest/helpers_test.go(1 hunks)cli/posts/handler_test.go(1 hunks)database/model_internal_test.go(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/tests.yml
🚧 Files skipped from review as they are similar to previous changes (5)
- database/model_internal_test.go
- cli/clitest/helpers.go
- cli/accounts/handler_test.go
- cli/posts/handler_test.go
- cli/accounts/factory_test.go
🔇 Additional comments (1)
cli/clitest/helpers_test.go (1)
8-13: LGTM! Clean validation test.The test correctly validates that
MakeTestEnv()returns an environment with a 32-byte master key, which is essential for cryptographic operations.
Summary
Testing
go test ./...https://chatgpt.com/codex/tasks/task_e_688c7d0396488333b732ec08e4119fdc
Summary by CodeRabbit