Skip to content

hotfix: Fix DNS#50

Merged
gocanto merged 3 commits intomainfrom
hotfix/fix-dns
Sep 12, 2025
Merged

hotfix: Fix DNS#50
gocanto merged 3 commits intomainfrom
hotfix/fix-dns

Conversation

@gocanto
Copy link
Copy Markdown
Contributor

@gocanto gocanto commented Sep 12, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Corrected reverse proxy target for relay traffic to ensure reliable connectivity.
  • Chores

    • Updated restart process to recreate the correct Caddy service for more consistent deployments.
    • Added a DNS alias on the network to improve service discovery and compatibility across containers.

No user-facing behavior changes; these updates improve stability and reliability of the service.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR updates Docker Compose and Caddy configuration: renames the restart target to caddy-prod in the Makefile, changes a Caddy reverse_proxy upstream from oullin_proxy_prod to proxy, and assigns a web DNS alias to the caddy-prod service on the caddy_net network.

Changes

Cohort / File(s) Summary of Changes
Caddy service targeting and networking
build/makefiles/caddy.mk, docker-compose.yml
Make target caddy-restart now recreates caddy-prod via docker compose. In compose, caddy-prod joins caddy_net with an added DNS alias web.
Reverse proxy upstream update
caddy/WebCaddyfile.internal
In the @relay handle block, the upstream changed from https://oullin_proxy_prod:8443 to https://proxy:8443; other TLS and transport settings unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client
  participant Caddy as Caddy (caddy-prod)
  participant Proxy as Upstream "proxy:8443"

  Note over Caddy: Runs on caddy_net with DNS alias "web"

  Client->>Caddy: HTTPS request (/relay...)
  activate Caddy
  Note over Caddy: Match @relay route<br/>URI replacement + mTLS
  Caddy->>Proxy: HTTPS reverse_proxy (mTLS)
  activate Proxy
  Proxy-->>Caddy: Response
  deactivate Proxy
  Caddy-->>Client: Response
  deactivate Caddy
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I nudge my paws, restart with cheer—
From web_caddy_prod to caddy-prod, it’s clear.
A proxy hop to “proxy” now, how neat,
On caddy_net I answer as “web,” so fleet.
Thump-thump goes CI—deploy complete! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b66df26 and 0620705.

📒 Files selected for processing (3)
  • build/makefiles/caddy.mk (1 hunks)
  • caddy/WebCaddyfile.internal (1 hunks)
  • docker-compose.yml (1 hunks)
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/fix-dns

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gocanto gocanto marked this pull request as ready for review September 12, 2025 08:33
@gocanto gocanto merged commit 01a0b07 into main Sep 12, 2025
4 of 5 checks passed
@gocanto gocanto deleted the hotfix/fix-dns branch September 12, 2025 08:36
@coderabbitai coderabbitai Bot mentioned this pull request May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant