[Remote Inference] Supported params are ignored#1562
Merged
Conversation
kaisopos
commented
Mar 26, 2025
| "stop_strings", | ||
| "stop_token_ids", | ||
| "min_p", | ||
| "guided_decoding", |
Contributor
Author
There was a problem hiding this comment.
Note: min_p and stop_token_ids were newly added here
kaisopos
commented
Mar 26, 2025
| return "OPENAI_API_KEY" | ||
|
|
||
| @override | ||
| def _convert_conversation_to_api_input( |
Contributor
Author
There was a problem hiding this comment.
This function could be omitted, since logit_bias is empty by default & the super function has been updated to NOT include logit_bias in the API call if empty. This fn will only protect the user if they unintentionally set this. It is questionable though if it's a better experience to silently ignore this or just fail.
wizeng23
reviewed
Mar 28, 2025
wizeng23
approved these changes
Mar 28, 2025
penfever
pushed a commit
that referenced
this pull request
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates:
Validating that all params are supported, before the remote API call.min_p,stop_token_ids) in_convert_conversation_to_api_input(base remote engine)logit_biasfor "o1-preview" (this model was not working before)self._model_params), this change allows users to update the model with a new inference config (inference_config.model) after the engine is instantiated. This allows users to use the same OpenAI engine for gpt-4, but later (without re-instantiating the engine) they can pass in a new config and run inference for OpenAI'so1-preview.Related issues
Fixes OPE-1123
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.