Conversation
nikg7
changed the title
wizeng23
approved these changes
Mar 25, 2025
| @@ -77,13 +80,20 @@ def _test_eval_impl( | |||
| config_path = test_config.config_path | |||
| # Overriding nested fields using OmegaConf's dot-list syntax is complicated, | |||
Contributor
There was a problem hiding this comment.
nit: Note that this should be possible now: #1430
penfever
pushed a commit
that referenced
this pull request
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-- Reset
shard_for_evaltoFalsefor e2e tests using 1 GPU (leads to errors otherwise)-- Optimize some test params e.g., move
iterative_logsto test specs (currently hardcoded)-- Update Phi3 eval config to use
bfloat16-- Tested e2e eval tests on
A100:1andA100:4Related issues
Towards OPE-909
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.