Fixes SlackWriter to evaluate the IO.#640
Merged
darkfrog26 merged 2 commits intooutr:masterfrom Oct 19, 2024
Merged
Conversation
This uses unsafeRunAndForget. This is not ideal, but currently there is no way to wire up an effectfull writer as far as I can tell. An effectfull writer would also need to be wired up in the application (maybe some would prefer this).
KristianAN
commented
Oct 17, 2024
|
|
||
| override def write(record: LogRecord, output: LogOutput, outputFormat: OutputFormat): Unit = { | ||
| val io = log(record) | ||
| val io = log(record) // Does nothing |
Author
There was a problem hiding this comment.
I don't think this actually does anything here. I'm guessing it used to work because it was a Future that would evaluate anyway. Then when rewritten to IO it is just not evaluated.
Contributor
There was a problem hiding this comment.
You're correct, this can be removed.
Move import to top level of file
KristianAN
changed the title
darkfrog26
approved these changes
Oct 19, 2024
|
|
||
| override def write(record: LogRecord, output: LogOutput, outputFormat: OutputFormat): Unit = { | ||
| val io = log(record) | ||
| val io = log(record) // Does nothing |
Contributor
There was a problem hiding this comment.
You're correct, this can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses unsafeRunAndForget. This is not ideal, but currently there is no way to wire up an effectfull writer as far as I can tell. An effectfull writer would also need to be wired up in the application (maybe some would prefer this).