Add Java Platform Logging bridge#727
Merged
darkfrog26 merged 2 commits intooutr:masterfrom Jul 18, 2025
Merged
Conversation
hygt
commented
Jul 17, 2025
darkfrog26
reviewed
Jul 18, 2025
Contributor
|
Thanks @hygt, this is a great addition. I have a few comments, but otherwise, very nice work! |
Contributor
|
Great work! |
Contributor
|
This has been published with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @darkfrog26
I thought a native
System.Loggerbridge could be useful, as its usage is becoming more widespread, this avoids the need to add the JPL -> SLF4J/log4j2 bridge, or worse, relying on JPL default JUL backend.The unit tests are mostly coming from the SLF4J bridges with JPL's peculiarities (
ResourceBundlecan hold aMessageFormatpattern).