fix pyinstaller-windows, using Msys2 #205
Merged
outscale-mgo merged 1 commit intomasterfrom Sep 9, 2022
Merged
Conversation
outscale-mgo
force-pushed
the
test-pyinstaller-windows
branch
16 times, most recently
from
181314e to
af5a3fb
Compare
outscale-mgo
changed the title
outscale-mdr
reviewed
Jul 4, 2022
| python --version | ||
| python -m pip install pyinstaller | ||
| python -m pip install . | ||
| pacman -Ql | grep openssl | grep dll |
outscale-mdr
suggested changes
Jul 4, 2022
pkg/Makefile
Outdated
| @echo '===========================================' | ||
| @echo -e '============= \033[31m WARNING !!!!! \033[m ============' | ||
| @echo '===========================================' | ||
| @echo -e '\033[5m\033[31mThis rule is deprercated, and most likely broken \033[m' |
pkg/Makefile
Outdated
| @@ -41,6 +41,13 @@ osc-cli-x86_64.zip: osc-cli | |||
| zip -r osc-cli-x86_64.zip osc-cli | |||
|
|
|||
| osc-cli: | |||
Contributor
Author
There was a problem hiding this comment.
well, I could, but as it was here before, I guess it should be done in another ticket PR.
Comment on lines
27
to
32
| run: | | ||
| git submodule update --init | ||
| python --version | ||
| python -m pip install pyinstaller | ||
| python -m pip install . | ||
| pacman -Ql | grep openssl | grep dll |
There was a problem hiding this comment.
Could we include this in the Makefile ? Even though we cannot run it on a Linux machine
Contributor
Author
There was a problem hiding this comment.
I could, but this is Msys2 specific, which even on windows isn't that use. so I'm not too sure about putting this part outside the yaml.
Especially as, one the debug remove, it's like a 3-line diff.
outscale-mgo
force-pushed
the
test-pyinstaller-windows
branch
2 times, most recently
from
24530ed to
adf0f62
Compare
jerome-jutteau
suggested changes
Jul 13, 2022
| uses: "marvinpinto/action-automatic-releases@latest" | ||
| if: ${{ github.event_name == 'push' }} | ||
| with: | ||
| repo_token: "${{ secrets.TOKEN_MGO }}" |
Contributor
There was a problem hiding this comment.
TOKEN_MGO? We probably already have a gh token available from our bot
pkg/Makefile
Outdated
| @echo -e '\033[5m\033[31mThis rule is deprecated, and most likely broken \033[m' | ||
| @echo '===========================================' | ||
| @echo -e '============= \033[31m \WARNING !!!!! \033[m ============' | ||
| @echo '===========================================' |
Contributor
There was a problem hiding this comment.
Why not removing old rule?
Contributor
Author
There was a problem hiding this comment.
can we do that in a second time, as this is still a very diferent way to package the windows cli.
outscale-mgo
force-pushed
the
test-pyinstaller-windows
branch
from
adf0f62 to
54198c9
Compare
jerome-jutteau
approved these changes
Aug 12, 2022
jerome-jutteau
approved these changes
Sep 1, 2022
As the Makefile use a docker that use wine that use pyinstaller, is currently broken, and is hard to debug, this new workflow, use windows directly with Msys 2 (which use the glorious Pacman from I use Arch BTW). I've also remove the old windwos build from everything. See you wine build, someday somewhere! fix #190
outscale-mgo
force-pushed
the
test-pyinstaller-windows
branch
from
52a89de to
89ff71f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.