Conversation
Signed-off-by: Jérôme Jutteau <jerome.jutteau@outscale.com>
jerome-jutteau
force-pushed
the
windows-packaging
branch
from
8605dd4 to
1861c04
Compare
outscale-mgo
suggested changes
Sep 3, 2021
| zip -r osc-cli-x86_64.zip osc-cli | ||
|
|
||
| osc-cli: | ||
| docker run --rm -it -v ${PWD}/..:/src outscale/wine-pyinstaller:0.0.1 --distpath ./pkg --clean --name osc-cli osc_sdk/sdk.py |
Contributor
There was a problem hiding this comment.
I don't understand what is outscale/wine-pyinstaller shouldn't you add a git submodule ? maybe add a rule to clone it and build the docker ?
Contributor
Author
There was a problem hiding this comment.
Its a docker image hosted on outscale-dev/wine-pyinstaller (which can be re-used for other projects as building windows binaries from Linux is really tricky, check details in the project).
No need to sub-module and build on the fly, docker run will fetch the image from docker hub and do the job for you.
outscale-mgo
approved these changes
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jérôme Jutteau jerome.jutteau@outscale.com