Add login/password auth#80
Merged
outscale-mgo merged 1 commit intomasterfrom Sep 1, 2022
Merged
Conversation
jerome-jutteau
force-pushed
the
login-password
branch
from
cf37f56 to
0a88332
Compare
outscale-mgo
suggested changes
Aug 23, 2022
| user_agent = DEFAULT_USER_AGENT): | ||
| self.access_key = credentials.get_ak() | ||
| self.secret_key = credentials.get_sk() | ||
| self.email = credentials.get_email() |
There was a problem hiding this comment.
TBH I'm not a big fan of those getter.
I would prefer if we use credentials.email, and so on.
| def get_url_extension(self): | ||
| return 'hk' if 'cn' in self.region else 'com' | ||
|
|
||
| def get_email(self): |
There was a problem hiding this comment.
As said before, I would prefer to remove the getter (in another PR), than add other getter, that are not really useful
closes #79 Signed-off-by: Jérôme Jutteau <jerome.jutteau@outscale.com>
jerome-jutteau
force-pushed
the
login-password
branch
from
0a88332 to
fce042c
Compare
outscale-mgo
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #79
Signed-off-by: Jérôme Jutteau jerome.jutteau@outscale.com