feat: improve auth requests UI and API calls#32
Merged
rafaelsilva29 merged 4 commits intomainfrom May 8, 2026
Merged
Conversation
rafaelsilva29
requested review from
ChiaraTroiani,
beryder,
copasseron,
hmuyal,
jadiaconu,
mayannuz,
melhelou-cisco and
mkedjour
as code owners
- Add dedicated GET /trace/session/{user_input_id} endpoint returning all session events sorted by creation time
- Add useSession hook consuming the new endpoint; remove all=true workaround from useTraces
- Convert EventType union to const object for type-safe comparisons across all consumers
- Extract ToolCheckFlags and TOTAL_TOOL_CHECKS to mas.types.ts, removing duplicated bitmask constants from 3 files
- Replace useMAS() with useMASById in SessionTraceSheet for targeted MAS name resolution
- Fix global search traces query to pass q to server instead of client-side filtering
- Fix ColumnDef to use import type in mas-columns.tsx
- Fix get_mas_by_id return type to MultiAgentSystem | None
- UI text capitalization audit: Title Case across filter labels, blocking reason labels, deny condition labels, view toggles, sidebar tooltip, pagination footer
Signed-off-by: Rafael Silva (rafaelsi) <rafaelsi@cisco.com>
rafaelsilva29
force-pushed
the
fix/improve-auth-requests
branch
from
ad630ce to
363abca
Compare
Signed-off-by: Rafael Silva (rafaelsi) <rafaelsi@cisco.com>
…/improve-auth-requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the auth requests UI and supporting API with several targeted cleanups:
New API endpoint:
GET /trace/session/{user_input_id}returns all events for a single session sorted by creation time, replacing the previous workaround of calling the paginated/traceendpoint withall=true.Frontend hooks: Added
useSessionhook that consumes the new endpoint with a dedicated query key andstaleTime. Removed theall=trueworkaround fromuseTraces.SessionTraceSheetnow usesuseMASByIdinstead ofuseMAS()to fetch the MAS name by ID directly, avoiding missed results on large deployments.Type safety: Converted
EventTypefrom a union type to aconstobject — all 6 consumer files updated to useEventType.*constants instead of raw string literals. ExtractedToolCheckFlagsandTOTAL_TOOL_CHECKStomas.types.tsas the single source of truth, removing duplicated bitmask constants frommas-deny-conditions-tab.tsx,mas-info-tab.tsx, andmas-detail-page.tsx.Global search: Fixed the traces query to pass
qto the server (matching how the MAS filter works) instead of fetching 100 results and filtering client-side.Minor fixes:
ColumnDefimport changed toimport type;get_mas_by_idreturn type corrected toMultiAgentSystem | None; UI text audit applied Title Case consistently across filter labels, blocking reason labels, deny condition labels, view toggles, sidebar tooltip, and pagination footer.Type of Change
Checklist