feat(web): restore last visited route across reloads

[ovdmar]

Summary

• Persist the most recently resolved route to localStorage["citadel:lastRoute"] via router.subscribe("onResolved", …). Saving on every navigation (not just beforeunload) makes this robust under reloads, full close+reopen, and PWA mode where unload events are unreliable.
• Before createRouter() boots, if the browser landed on the bare app root (pathname === "/", no query, no hash), call history.replaceState with the saved route so the router's initial location is already the restored URL — no flash of the cockpit, no second navigation that could feed back into the subscriber.
• Deep links always win: any explicit URL (non-root path, or root with query/hash) skips the restore.
• A new defaultNotFoundComponent clears the saved key, so a stale persisted route (removed page, etc.) can't loop the user into 404 on every boot.

Why

User feedback (verbatim): "reloading or changing page and coming back should always lead to your last visited page — even if you completely close it and reopen it should still have you on the latest page." Today the app always lands on the default cockpit view regardless of where the user was.

Excluded routes

None deliberately excluded — EXCLUDED_PREFIXES in apps/web/src/lib/last-route.ts is intentionally empty so /onboarding is restored too (a user who closes mid-setup resumes in the wizard). Hook is in place for future per-route exclusions.

Test plan

• pnpm typecheck
• pnpm lint
• pnpm test — full suite green, including 5 new unit tests for last-route.ts (round-trip, clear, non-absolute href rejection, bare-root landing detection)
• Manual: navigate to /operations, reload → still on /operations
• Manual: navigate to /operations, close tab, reopen / → lands on /operations
• Manual: open /settings directly (deep link) → stays on /settings, doesn't get overridden by any previously saved value
• Manual: persist a stale path by hand in DevTools (e.g. /no-such-route) and reload → renders NotFound, key is cleared, next reload lands on /

🤖 Generated with Claude Code

[ovdmar]

Self-review pass on the current diff. Three findings below — each tied to a specific line.

[ovdmar]

Finding 1 — saves the path of a 404 before NotFoundView clears it.

When the persisted route is stale (route removed, etc.), the sequence is: onResolved fires → subscriber writes the bad path back to localStorage → React commits NotFoundView → useEffect calls clearLastRoute. The clear happens last so the steady state is correct, but there is a window during which localStorage holds an invalid value. If the tab is closed in that window, the next boot replays the same bad route.

Cleaner: short-circuit the subscriber when router.state.statusCode is non-2xx, so we never write a path that didn't resolve to a real match.

[ovdmar]

Resolved in c8fb32e. Subscriber now reads router.state.statusCode and short-circuits on >= 400 — bad paths never make it into localStorage, even transiently.

[ovdmar]

Finding 2 — boot-time restore decision is not tested.

The unit tests cover the storage layer (loadLastRoute/saveLastRoute/isBareRootLanding) but not the actual decision being made here: "bare root + saved value ≠ '/' → replaceState". That logic is what the user-facing requirement hinges on. Extract it into a small pure function (bootstrapLastRoute(location, history, storage)) and add tests covering: bare root with saved route, bare root with no saved route, bare root where saved equals '/', and deep-link landing.

[ovdmar]

Resolved in c8fb32e. Extracted bootstrapLastRoute(location, history, storage) and added five tests: bare-root restore, no-saved-value, saved-equals-/, deep-link non-root pathname, deep-link on / with query string. main.tsx now just calls the function.

[ovdmar]

Finding 3 — NotFoundView is referenced on line 90 before its declaration on line 114.

Works via function hoisting, but readers tracing the createRouter config have to scan past the bottom of the file. Move the declaration up so the reading order matches the dependency order.

[ovdmar]

Resolved in c8fb32e. Shell and NotFoundView moved above the route table / createRouter call so reading order matches dependency order.

[ovdmar]

Re-review pass after c8fb32e. All three previous findings have been addressed (replies posted on each comment). No new findings on the current diff:

• Subscriber timing against router.state.statusCode verified against TanStack source — statusCode is updated by loadMatches before onResolved is emitted.
• useEffect deps are stable (module-level imports).
• Router lives for app lifetime so the discarded unsubscribe handle is intentional.
• typecheck + lint + 103 tests green locally.

Ready for human review/merge.