crypto.createDiffieHellman very slow when prime length is big

[Mrpotatosse]

What version of Bun is running?

1.0.30+1424a196f

What platform is your computer?

Linux 5.15.146.1-microsoft-standard-WSL2 x86_64 x86_64

What steps can reproduce the bug?

just use this code

import crypto from "crypto";

console.time("prime generate");
const arbitre = crypto.createDiffieHellman(2048);
console.timeEnd("prime generate");

What is the expected behavior?

something like this:

[8.00s] prime generate

What do you see instead?

i do not see nothing, it keeps running forever ( ok not forever i stopped it after 10 minutes )

Additional information

No response

[Mrpotatosse]

update: it took 4726.32 seconds....

[andenacitelli]

Easily reproducible, notably also at much lower Diffie-Hellman key sizes (512 is seemingly the lowest Diffie-Hellman allows), which may make the debugging process quicker.

Bun 1.0.30, M2 Mac

Script

import crypto from "crypto";
crypto.createDiffieHellman(512);

Benchmarks:

Regular Node is quite quick:

➜  sandbox hyperfine "node main.js"
Benchmark 1: node main.js
  Time (mean ± σ):     100.2 ms ±  30.9 ms    [User: 91.8 ms, System: 6.6 ms]
  Range (min … max):    49.9 ms … 162.3 ms    27 runs

Bun is tragically slow. I was too impatient to wait for a full benchmarking run, as it usually takes at least thirty seconds.

[Jarred-Sumner]

these node:crypto functions are implemented via a browserify JS polyfill and it's terribly slow

we will fix it but not until after Windows

[birkskyum]

Hit a crash with DiffieHellman not being available today. Looking forward to node:crypto

[jlucaso1]

Updates on this. Tried on recent canary:

02:19:25 jlucaso@jlucaso temp → bat bench.ts
───────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: bench.ts
───────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ import crypto from "node:crypto";
   2   │
   3   │ console.time("prime generate");
   4   │ const arbitre = crypto.createDiffieHellman(2048);
   5   │ console.timeEnd("prime generate");
───────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────
02:19:33 jlucaso@jlucaso temp → bun run bench.ts
[6.39s] prime generate
02:19:43 jlucaso@jlucaso temp → node bench.ts
(node:317591) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
prime generate: 10.290s
02:20:01 jlucaso@jlucaso temp → deno run bench.ts
prime generate: 1277ms
02:20:06 jlucaso@jlucaso temp → bun -v
1.2.6

[kravetsone]

Updates on this. Tried on recent canary:

02:19:25 jlucaso@jlucaso temp → bat bench.ts
───────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: bench.ts
───────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ import crypto from "node:crypto";
   2   │
   3   │ console.time("prime generate");
   4   │ const arbitre = crypto.createDiffieHellman(2048);
   5   │ console.timeEnd("prime generate");
───────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────
02:19:33 jlucaso@jlucaso temp → bun run bench.ts
[6.39s] prime generate
02:19:43 jlucaso@jlucaso temp → node bench.ts
(node:317591) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
prime generate: 10.290s
02:20:01 jlucaso@jlucaso temp → deno run bench.ts
prime generate: 1277ms
02:20:06 jlucaso@jlucaso temp → bun -v
1.2.6

Can u check canary version/revision?

Bun recently rewrite it to native code

#17850

[Jarred-Sumner]

This is fixed. it's still slow, but now we're around the same performance as node instead of dramatically different:

❯ node a.js
prime generate: 45.124s

❯ bun a.js
[13.23s] prime generate

Thanks to @dylan-conway in #17850