Skip to content

Introduce Bun.Cookie & Bun.CookieMap & request.cookies (in BunRequest)#18073

Merged
Jarred-Sumner merged 21 commits intomainfrom
jarred/cookie
Mar 21, 2025
Merged

Introduce Bun.Cookie & Bun.CookieMap & request.cookies (in BunRequest)#18073
Jarred-Sumner merged 21 commits intomainfrom
jarred/cookie

Conversation

@Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Mar 11, 2025

What does this PR do?

WIP

Fixes BUN-11875

@robobun
Copy link
Collaborator

robobun commented Mar 11, 2025

Updated 8:09 PM PT - Mar 20th, 2025

@pfgithub, your commit 1ac4813 has 1 failures in Build #13664:


🧪   try this PR locally:

bunx bun-pr 18073

sameSite?: CookieSameSite;
httpOnly?: boolean;
partitioned?: boolean;
maxAge?: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

number | Date maybe?

@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review March 21, 2025 04:28
@Jarred-Sumner Jarred-Sumner merged commit 9888570 into main Mar 21, 2025
66 of 71 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/cookie branch March 21, 2025 04:29
Jarred-Sumner added a commit that referenced this pull request Mar 22, 2025
…nRequest) (#18073)"

This reverts commit 9888570.

We will add it in Bun v1.2.7
pfgithub added a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants