Conversation
Collaborator
|
Updated 11:58 AM PT - Mar 19th, 2025
❌ @Electroid, your commit 2e4139d has some failures in 🧪 try this PR locally: bunx bun-pr 18140 |
Electroid
force-pushed
the
node-test
branch
2 times, most recently
from
e2d136c to
e7ce6da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds initial support for the
node:testmodule. Behind the scenes, it usesbun:test, so the test experience can be the same.Most tests should just work, but there are missing features including:
How did you verify your code works?
Tests were added. This also unblocks about 19 Node.js tests, that previously failed.