Skip to content

fix(serve): make error messages for invalid fetch() clearer #18260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DonIsaac wants to merge 3 commits into from
Closed

fix(serve): make error messages for invalid fetch() clearer #18260

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d50add
fix(serve): make error messages for invalid fetch() clearer
DonIsaac Mar 17, 2025
2af23f7
type fix
DonIsaac Mar 17, 2025
9eb2216
Merge branch 'main' into don/fix/confusing-fetch-err-message
DonIsaac Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/bun.js/api/server.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ const ctxLog = Output.scoped(.RequestContext, false);
const S3 = bun.S3;
const SocketAddress = @import("bun/socket.zig").SocketAddress;

const bun_docs_url = "https://bun.sh/docs";

const BlobFileContentResult = struct {
data: [:0]const u8,

Expand Down Expand Up @@ -1674,7 +1676,16 @@ pub const ServerConfig = struct {

if (try arg.getTruthy(global, "fetch")) |onRequest_| {
if (!onRequest_.isCallable()) {
return global.throwInvalidArguments("Expected fetch() to be a function", .{});
if (onRequest_.isUndefined()) {
return global.throwInvalidArguments(
"Bun.serve() requires a fetch() function to handle incoming requests. For more information, see " ++ bun_docs_url ++ "api/http#bun-serve",
Copy link
Contributor

@paperclover paperclover Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought that we should accept routes and/or fetch, so this error message isn't exactly right.

also getTruthy avoids undefined already so this is not going to be hit

.{},
);
} else {
const ty = try global.determineSpecificType(onRequest_);
defer ty.deref();
return global.throwInvalidArguments("Expected 'fetch()' to be a function, got {s}", .{ty});
}
}
const onRequest = onRequest_.withAsyncContextIfNeeded(global);
JSC.C.JSValueProtect(global, onRequest.asObjectRef());
Expand Down