node:crypto: implement generatePrime(Sync) and checkPrime(Sync)#18268
Merged
Jarred-Sumner merged 14 commits intomainfrom Mar 18, 2025
Merged
node:crypto: implement generatePrime(Sync) and checkPrime(Sync)#18268Jarred-Sumner merged 14 commits intomainfrom
node:crypto: implement generatePrime(Sync) and checkPrime(Sync)#18268Jarred-Sumner merged 14 commits intomainfrom
Conversation
Collaborator
|
Updated 11:08 PM PT - Mar 17th, 2025
❌ @dylan-conway, your commit 63e62e5 has 1 failures in
🧪 try this PR locally: bunx bun-pr 18268 |
|
@dylan-conway just a side note, I think you missed an update on the NodeJS compatibility doc in your PR, cheers
|
Member
Author
|
@ghiscoding thanks for the reminder. Will update the docs soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
test-crypto-prime.js