Implement vm.compileFunction and fix some node:vm tests#18285
Merged
Jarred-Sumner merged 36 commits intomainfrom Mar 21, 2025
Merged
Implement vm.compileFunction and fix some node:vm tests#18285Jarred-Sumner merged 36 commits intomainfrom
vm.compileFunction and fix some node:vm tests#18285Jarred-Sumner merged 36 commits intomainfrom
Conversation
also changed in oven-sh/WebKit
Collaborator
|
Updated 7:37 PM PT - Mar 20th, 2025
❌ @zackradisic, your commit 16674f2 has 1 failures in
🧪 try this PR locally: bunx bun-pr 18285 |
Contributor
Author
|
The |
| auto source_url = stack_frame.sourceURL(vm); | ||
| if (source_url.isEmpty()) { | ||
| // copy what Node does | ||
| source_url = "evalmachine.<anonymous>"_s; |
Collaborator
There was a problem hiding this comment.
They hardcode evalmachine.?
Contributor
Author
There was a problem hiding this comment.
The output comes from V8 so I put this to match it
Contributor
Author
There was a problem hiding this comment.
Actually they do hardcode this: https://github.com/nodejs/node/blob/afe3909483a2d5ae6b847055f544da40571fb28d/lib/vm.js#L94
Contributor
|
this broke
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
vm.compileFunction(missing codeCache options)test-vm-is-context.jstest-vm-context.jstest-vm-syntax-error-stderr.jstest-vm-run-in-new-context.jstest-vm-api-handles-getter-errors.jstest-vm-strict-assign.jstest-vm-options-validation.js