Fix connection event being emitted multiple times per socket in node:http#18295
Merged
Jarred-Sumner merged 1 commit intomainfrom Mar 19, 2025
Merged
Fix connection event being emitted multiple times per socket in node:http#18295Jarred-Sumner merged 1 commit intomainfrom
connection event being emitted multiple times per socket in node:http#18295Jarred-Sumner merged 1 commit intomainfrom
Conversation
Collaborator
|
Updated 8:45 PM PT - Mar 18th, 2025
❌ @heimskr, your commit d59817a has 2 failures in
🧪 try this PR locally: bunx bun-pr 18295 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where
node:httpservers would emitconnectionevents multiple times for the same socket. This would cause Vite to accumulate excesscloselisteners on sockets.How did you verify your code works?
I ran an example Vite app (
/examples/webin sroussey/ellmers) and spammed refresh in Firefox while checking for warnings about too manycloselisteners. I also ran thenode:httptests.