Skip to content

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Mar 26, 2025

What does this PR do?

Fixes #18505

Other changes:

  • Pack Pattern's boolean fields into a packed Flags struct

How did you verify your code works?

I have added a test

@DonIsaac DonIsaac added the bun install Something that relates to the npm-compatible client label Mar 26, 2025
@DonIsaac DonIsaac requested a review from dylan-conway March 26, 2025 23:00
@robobun
Copy link
Collaborator

robobun commented Mar 26, 2025

@DonIsaac DonIsaac requested a review from dylan-conway March 28, 2025 22:03
Copy link
Member

@dylan-conway dylan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After LICENSE comment is addressed this looks good to go

@dylan-conway dylan-conway merged commit f0dfa10 into main Mar 29, 2025
41 of 52 checks passed
@dylan-conway dylan-conway deleted the don/fix/package-exclude-files branch March 29, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bun install Something that relates to the npm-compatible client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bun publish does not respect excluded files nested within included directories

5 participants