fix(pack): use case-insensitive equality on all platforms#18682
Closed
fix(pack): use case-insensitive equality on all platforms#18682
Conversation
Collaborator
|
Updated 6:16 PM PT - Apr 9th, 2025
❌ @DonIsaac, your commit a9ae300 has 1 failures in
🧪 try this PR locally: bunx bun-pr 18682 |
| strings.eqlComptime | ||
| else | ||
| strings.eqlCaseInsensitiveASCIIICheckLength; | ||
| const stringsEql = strings.eqlCaseInsensitiveASCIIICheckLength; |
Member
There was a problem hiding this comment.
Suggested change
| const stringsEql = strings.eqlCaseInsensitiveASCIIICheckLength; |
let's just delete this and replace it's one usage
Contributor
Author
There was a problem hiding this comment.
its just... such a long name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When checking if files should or should not be included/excluded, we currently use a case-insensitive string equality check only on linux. This PR changes
bun pm packandbun publishto always use a case-insensitive check on all platforms. This conforms to npm's behavior.How did you verify your code works?
I've added tests.