fix: errors found by -Werror on Clang 20 #18877
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated 12:43 PM PT - Apr 9th, 2025
❌ @DonIsaac, your commit eaeb798 has 2 failures in
🧪 try this PR locally: bunx bun-pr 18877 |
190n
reviewed
Apr 8, 2025
Comment on lines
-4994
to
+4995
| auto view = WTF::StringView(function->name()); | ||
| String name = function->name(); | ||
| auto view = WTF::StringView(name); |
Contributor
There was a problem hiding this comment.
Interesting, what was the error message here?
Contributor
Author
There was a problem hiding this comment.
StringView using a String that was created but immediately thrown away
Contributor
There was a problem hiding this comment.
Nice, but it's also dubious that we pass it to toZigString right after since that uses the same pointer. What I'm wondering is if the function owns name() (this seems likely, but I haven't investigated fully) or if it's making a new string when we call it.
If it's owned by the function, then this is fine, but if it's a new string then even the changed code is still broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
-Werrorviolations found by clang v20bun.assertfHow did you verify your code works?
If it compiles, it works