Experiment: call ZigString__freeGlobal when calling deref on an exter… #19452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

Jarred-Sumner wants to merge 1 commit into main from jarred/experiment-deref

+46 −36

Collaborator

Jarred-Sumner commented May 3, 2025

…nal string

What does this PR do?

Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes

How did you verify your code works?


          Experiment: call ZigString__freeGlobal when calling deref on an exter…

6c5fcf2

…nal string

Collaborator

robobun commented May 3, 2025 •

edited

Loading

^{Updated 11:21 PM PT - May 2nd, 2025}

❌ @Jarred-Sumner, your commit 6c5fcf2 has 2 failures in Build #16050:

cmake/tools/SetupBuildkite.cmake - cmake warning on 🪟 x64-baseline - build-bun
CMakeLists.txt - cmake warning on 🪟 x64-baseline - build-bun
cmake/tools/SetupBuildkite.cmake - cmake warning on 🪟 x64 - build-bun
CMakeLists.txt - cmake warning on 🪟 x64 - build-bun
scripts/build.mjs - build failed on 🍎 x64 - build-bun
scripts/build.mjs - build failed on 🪟 x64-baseline - build-bun
scripts/build.mjs - build failed on 🍎 aarch64 - build-bun
scripts/build.mjs - build failed on 🪟 x64 - build-bun
scripts/build.mjs - build failed on 🐧 x64-asan - build-bun
scripts/build.mjs - build failed on 🐧 x64-musl - build-bun
scripts/build.mjs - build failed on 🐧 aarch64-musl - build-bun
scripts/build.mjs - build failed on 🐧 aarch64 - build-bun
scripts/build.mjs - build failed on 🐧 x64-musl-baseline - build-bun
scripts/build.mjs - build failed on 🐧 x64 - build-bun
scripts/build.mjs - build failed on 🐧 x64-baseline - build-bun

🧪 try this PR locally:

bunx bun-pr 19452
bun-19452 --bun # ...args to pass to bun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet