Add "did you mean" for bun run scripts that are mistyped
#19493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated 11:30 PM PT - May 5th, 2025
✅ @Jarred-Sumner, your commit f9919b0bdd34369aff45a4c64ab2ef55784c22f9 passed in 🧪 To try this PR locally: bunx bun-pr 19493That installs a local version of the PR into your bun-19493 --bun |
Jarred-Sumner
requested review from
a team,
nektro and
paperclover
and removed request for
a team and
paperclover
Contributor
|
Do we want to use the |
nektro
reviewed
May 6, 2025
| &.{ "b", CSI ++ "1m" }, | ||
| &.{ "d", CSI ++ "2m" }, | ||
| &.{ "i", CSI ++ "3m" }, | ||
| &.{ "u", CSI ++ "4m" }, |
Contributor
There was a problem hiding this comment.
can you update the doc comment?
|
|
||
| /// Calculate the Jaro-Winkler similarity between two strings. | ||
| /// Returns a value between 0.0 (completely different) and 1.0 (identical). | ||
| fn jaroWinkler(s1: []const u8, s2: []const u8) f64 { |
Contributor
There was a problem hiding this comment.
how does Jaro-Winkler compare with Levenshtein?
Collaborator
Author
There was a problem hiding this comment.
its better imo
| argv0.len -= extname.len; | ||
| } | ||
|
|
||
| Output.prettyError("\nDid you mean \"{s}\"?\n\n <cyan><d>{s} <r><cyan><u>{s}<r>\n", .{ entry, argv0, entry }); |
Contributor
There was a problem hiding this comment.
does this have the correct output for both bun devv and bun run devv ? and can there be a test for that
Collaborator
Author
There was a problem hiding this comment.
needs a test yeah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a "did you mean" suggestion for similarly-named package.json scripts. It only appears for package.json scripts if it finds one that is similarly named. To choose a similarly named command, it uses Jaro-Winkler with a distance of 0.7, which is what clap uses.
How did you verify your code works?
Test