fix `test-http-client-finished.js` #19610

dylan-conway · 2025-05-12T20:07:30Z

What does this PR do?

WIP

How did you verify your code works?

test

robobun · 2025-05-12T20:07:39Z

^{Updated 2:00 PM PT - May 12th, 2025}

❌ @dylan-conway, your commit 5307dbd has 13 failures in Build #16510:

test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http-write-callbacks.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-response-statuscode.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-outgoing-end-types.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-abort-stream-end.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http-client-keep-alive-release-before-finish.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-outgoing-write-types.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 3.21 x64-baseline
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-buffer-sanity.js - code 1 on 🐧 20.04 x64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🍎 13 aarch64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🍎 14 aarch64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🪟 2019 x64-baseline
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🪟 2019 x64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 12 x64-asan
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 12 aarch64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 24.04 aarch64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 20.04 aarch64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🍎 13 x64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🍎 14 x64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 3.21 aarch64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 12 x64-baseline
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 3.21 x64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 24.04 x64-baseline
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 20.04 x64-baseline
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 3.21 x64-baseline
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 20.04 x64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 12 x64
test/js/node/cluster/test-worker-no-exit-http.ts - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🍎 14 aarch64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 12 x64-asan
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 3.21 aarch64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 3.21 x64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-end-throw-socket-handling.js - code 1 on 🐧 3.21 x64-baseline

🧪 To try this PR locally:

bunx bun-pr 19610

That installs a local version of the PR into your bun-19610 executable, so you can run:

bun-19610 --bun

cirospaciari · 2025-05-12T20:14:25Z

src/js/node/_http_server.ts

    if (typeof optionalCallback === "function") setCloseCallback(this, optionalCallback);
    this.listening = false;
-    server.stop();
+    server.stop(true);


this will force close all connections instead of graceful shutdown

maybe fix

5307dbd

cirospaciari reviewed May 12, 2025

View reviewed changes

dylan-conway closed this Jul 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix `test-http-client-finished.js` #19610

fix `test-http-client-finished.js` #19610

dylan-conway commented May 12, 2025

Uh oh!

robobun commented May 12, 2025 •

edited

Loading

Uh oh!

cirospaciari May 12, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix test-http-client-finished.js #19610

fix test-http-client-finished.js #19610

Conversation

dylan-conway commented May 12, 2025

What does this PR do?

How did you verify your code works?

Uh oh!

robobun commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cirospaciari May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix `test-http-client-finished.js` #19610

fix `test-http-client-finished.js` #19610

robobun commented May 12, 2025 •

edited

Loading

cirospaciari May 12, 2025 •

edited

Loading