Skip to content

Conversation

@dylan-conway
Copy link
Member

@dylan-conway dylan-conway commented May 12, 2025

What does this PR do?

fixes:

  • test-http-timeout-overflow.js
  • test-http-timeout.js
  • test-http-timeout-client-warning.js
  • test-http-outgoing-settimeout.js

Adds ClientRequest.prototype.clearTimeout and changes millisecond validation to use getTimerDuration instead of validateMsecs

How did you verify your code works?

this is a simple change, not sure if a custom test is necessary

@robobun
Copy link
Collaborator

robobun commented May 12, 2025

Updated 7:39 PM PT - May 14th, 2025

@Jarred-Sumner, your commit 1a434bc has 1 failures in Build #16632:


🧪   To try this PR locally:

bunx bun-pr 19612

That installs a local version of the PR into your bun-19612 executable, so you can run:

bun-19612 --bun

@dylan-conway dylan-conway requested review from a team, cirospaciari and pfgithub and removed request for a team May 13, 2025 21:30
pfgithub
pfgithub previously approved these changes May 13, 2025
@Jarred-Sumner Jarred-Sumner merged commit 45198e1 into main May 15, 2025
58 of 59 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/fix-test-http-timeout-overflow branch May 15, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants