Fix bundler_compile.test.ts #19633
Merged
Fix bundler_compile.test.ts #19633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update expectation for new react@next version - Pin React version so this is more stable going forward - Fix some TypeScript errors
Collaborator
|
Updated 12:21 PM PT - May 13th, 2025
✅ @190n, your commit df513fc2c2c1f3ebde8f52fa2a3e28f3ed400e66 passed in 🧪 To try this PR locally: bunx bun-pr 19633That installs a local version of the PR into your bun-19633 --bun |
| const NODE_ENV = minify ? "'production'" : undefined; | ||
| itBundled("compile/ReactSSR" + (bytecode ? "+bytecode" : "") + "+" + format + (minify ? "+minify" : ""), { | ||
| install: ["react@next", "react-dom@next"], | ||
| install: ["react@19.2.0-canary-b94603b9-20250513", "react-dom@19.2.0-canary-b94603b9-20250513"], |
Member
There was a problem hiding this comment.
it would be nice if itBundled supported lockfiles so we could be sure transitive dependencies don't change
dylan-conway
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
I ran the test