Skip to content

Conversation

@alii
Copy link
Member

@alii alii commented May 20, 2025

…nce routes/static breaks the existing api)

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

…nce routes/static breaks the existing api)
@robobun
Copy link
Collaborator

robobun commented May 20, 2025

Updated 11:31 PM PT - May 21st, 2025

@alii, your commit 167a7b2 has 1 failures in Build #17102:


🧪   To try this PR locally:

bunx bun-pr 19780

That installs a local version of the PR into your bun-19780 executable, so you can run:

bun-19780 --bun

@RiskyMH RiskyMH added the docs Improvements or additions to documentation label May 20, 2025
@RiskyMH
Copy link
Contributor

RiskyMH commented May 20, 2025

fixes second part of #19246 :)

@chevcast
Copy link

chevcast commented Jun 3, 2025

Gross. I really hope this doesn't become the official way to type socket context data.

@alii
Copy link
Member Author

alii commented Jul 8, 2025

@chevcast I agree it's not great. This was a symptom of the fact that adding routes: {} broke the WebSocket data. Unfortunately it's non-trivial to fix without partial type parameter inference

The reason this PR hasn't merged yet is because it might be even more confusing to have an "official" temporary workaround until either we are able to decide on a suitable breaking change for Bun.serve, or TypeScript implements partial type parameter inference.

@alii alii marked this pull request as draft July 8, 2025 20:32
@alii
Copy link
Member Author

alii commented Jul 15, 2025

Closing as fixing in #20918

@alii alii closed this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants