Add support for node:vm.SyntheticModule #19878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfgithub
reviewed
May 28, 2025
2 tasks
| extern "C" BunString BunString__createAtom(const char* bytes, size_t length) | ||
| { | ||
| ASSERT(simdutf::validate_ascii(bytes, length)); | ||
| auto atom = tryMakeAtomString(String(StringImpl::createWithoutCopying({ bytes, length }))); |
Member
There was a problem hiding this comment.
this isn't part of this pr, but we aren't checking for atom.isNull() here. should we change this to makeAtomString?
pfgithub
reviewed
Jun 3, 2025
nektro
reviewed
Jun 3, 2025
pfgithub
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for node:vm's SyntheticModule class. Also adds some other improvements to node:vm.
How did you verify your code works?
Added tests from Node.js