Skip to content

Conversation

@Jarred-Sumner
Copy link
Collaborator

Summary

  • document bun pm audit
  • include page in nav

Testing

  • node_modules/.bin/prettier --write docs/install/audit.md docs/nav.ts

@robobun
Copy link
Collaborator

robobun commented May 24, 2025

Updated 9:28 PM PT - May 26th, 2025

@alii, your commit 641a89f has 2 failures in Build #17403:


🧪   To try this PR locally:

bunx bun-pr 19885

That installs a local version of the PR into your bun-19885 executable, so you can run:

bun-19885 --bun

@Jarred-Sumner Jarred-Sumner requested a review from alii May 24, 2025 08:12
@Jarred-Sumner
Copy link
Collaborator Author

@alii it probably shouldn’t exit with code 0 when --json is used?

@alii
Copy link
Member

alii commented May 24, 2025

@Jarred-Sumner that was a concious choice - to me it felt like the success path here was "we were able to fetch the JSON report" and a failure is like network error, etc

Decided to exit with code 1 since npm does the same thing under --json

alii
alii previously approved these changes May 27, 2025
@alii alii marked this pull request as ready for review May 27, 2025 03:00
@Jarred-Sumner Jarred-Sumner merged commit a8e4489 into main May 27, 2025
58 of 61 checks passed
@Jarred-Sumner Jarred-Sumner deleted the codex/write-documentation-for-bun-pm-audit branch May 27, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants