fix(tty): restore cursor visibility on process exit#26643
Open
fix(tty): restore cursor visibility on process exit#26643
Conversation
When stdout is a TTY, write the cursor-show escape sequence (\x1b[?25h) in bun_restore_stdio() before restoring termios settings. Many CLI applications (like Ink) hide the cursor during operation and rely on cleanup handlers to restore it. On macOS, if the process exits before the cursor-show sequence is flushed, the cursor remains invisible in the terminal. This fix ensures the cursor is always visible after Bun exits, regardless of how the process terminates. Fixes #26642 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
Contributor
WalkthroughAdds terminal cursor visibility restoration to Bun's exit cleanup process for TTY outputs, ensuring the cursor is shown on exit. Includes a regression test verifying this behavior on non-Windows platforms. Changes
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\x1b[?25h) before restoring termios settings on process exitTest plan
test/regression/issue/26642.test.ts(runs on macOS only due to PTY requirements)🤖 Generated with Claude Code