Skip to content

Conversation

@Inego
Copy link
Contributor

@Inego Inego commented Aug 24, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
License MIT

Fix some typos and improve phrasing in the MD documents of the "Security" section.

Jeremiah VALERIE and others added 30 commits March 13, 2018 07:55
Add a NAME constant in generated type classes
…iptions

Dump schema: Adds option to export schema with descriptions
Update custom exception mapping doc
A minor typo fix because of YAML parse error for the double usage of simple quotes
Fixed typos and changed the wording slightly.
User Deprecated: Referencing controllers with a single colon is deprecated since Symfony 4.1
add the slide GraphQL in Symfony *by Bernd Alter*
@mcg-web
Copy link
Contributor

mcg-web commented Aug 24, 2018

Thank you @Inego! But can you please change the target branch from master to latest stable version 0.11 please?

@Inego Inego changed the base branch from master to 0.11 August 24, 2018 05:53
@Inego
Copy link
Contributor Author

Inego commented Aug 24, 2018

Done, but this's begun to look scary.

@Inego
Copy link
Contributor Author

Inego commented Aug 24, 2018

I'd better make a different PR.

@Inego Inego closed this Aug 24, 2018
@Inego
Copy link
Contributor Author

Inego commented Aug 24, 2018

IMO it should be stated in the "Contribution" section what branches to base contributions on.

@mcg-web
Copy link
Contributor

mcg-web commented Aug 24, 2018

yes I'll add this @Inego, thank you for contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.