fix(server/groups): add restriction to setgroup command#244
Merged
LukeWasTakenn merged 1 commit intooverextended:mainfrom Apr 13, 2025
Merged
fix(server/groups): add restriction to setgroup command#244LukeWasTakenn merged 1 commit intooverextended:mainfrom
LukeWasTakenn merged 1 commit intooverextended:mainfrom
Conversation
Signed-off-by: Marco <68809193+Zockerp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I noticed that the setgroup command does not appear to have any permission checks, such as restricted: group.admin or something similar.
If I'm understanding the current implementation correctly, this would mean that any user can execute the command and assign themselves to any group, including admin-level groups. This could potentially lead to serious security and access control issues.
Could you confirm whether this is intended behavior or an oversight?
In this PR, I’ve added a restriction requiring the group.admin permission.
Thanks in advance!