Skip to content

Typo#3

Merged
LukeWasTakenn merged 1 commit intooverextended:mainfrom
bdxndev:patch-1
Feb 23, 2022
Merged

Typo#3
LukeWasTakenn merged 1 commit intooverextended:mainfrom
bdxndev:patch-1

Conversation

@bdxndev
Copy link
Copy Markdown
Contributor

@bdxndev bdxndev commented Feb 21, 2022

Typo fix

Typo fix
Copy link
Copy Markdown
Member

@LukeWasTakenn LukeWasTakenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are changing the export name you also need to change the name where the component is being imported.

@bdxndev
Copy link
Copy Markdown
Contributor Author

bdxndev commented Feb 23, 2022

I checked all others and nothing shows other occurances

@LukeWasTakenn
Copy link
Copy Markdown
Member

I checked all others and nothing shows other occurances

Reason why I said that is because the provider is imported in the index.tsx file but apparently even though the export was typo'd it still wasn't throwing an error which is a bit weird but alright.

import CharactersProvider from './providers/CharactersProvider';

@LukeWasTakenn LukeWasTakenn merged commit af2b554 into overextended:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants