feat(web/dialog): Support default values#66
Merged
LukeWasTakenn merged 5 commits intooverextended:masterfrom Aug 5, 2022
Merged
feat(web/dialog): Support default values#66LukeWasTakenn merged 5 commits intooverextended:masterfrom
LukeWasTakenn merged 5 commits intooverextended:masterfrom
Conversation
LukeWasTakenn
approved these changes
Aug 5, 2022
Member
LukeWasTakenn
left a comment
LukeWasTakenn
left a comment
There was a problem hiding this comment.
Works well, do you want to do default for select as well?
You'd have to pass one of the values to a default property then iterate the options array and if it matches one of the values call the handleChange function for that value, otherwise just don't set any defaults.
Could you also please update the documentation?
Member
Author
|
LukeWasTakenn
approved these changes
Aug 5, 2022
Member
LukeWasTakenn
left a comment
LukeWasTakenn
left a comment
There was a problem hiding this comment.
Awesome, thank you so much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.