feat(locale): support nested key references in phrase interpolation#766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Locale files can already contain nested objects, and
locale('parent.child')resolves them correctly becauseflattenDictruns at load time. Phrase interpolation with${...}is the only place this breaks down: the resolver looks names up in the un-flattened nested table, so${parent.child}silently fails to substitute even though the same key is reachable via a directlocale()call.This patch threads the already-flattened dict through the resolver so both lookup paths behave the same. Top-level references keep working; nested references start working as a side effect.
Example
locales/en.json:{ "greeting": "Hello", "user": { "name": "Kenshin13" }, "msg": "${greeting}, ${user.name}!" }