feat(mongodb): simplify mongodb connection manager#24
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the MongoDB connection manager to act as a thin singleton wrapper around a single long-lived, lazily-connected MongoClient, removing the previous “cleanup/inactivity timeout” behavior and updating examples/docs accordingly.
Changes:
- Refactors
MongoConnectionManagerto lazy-connect once, share an in-flight connection promise, and expose aclose()API for graceful shutdown. - Adds unit tests covering singleton behavior, concurrent connection, retry-on-failure, and close/reconnect semantics.
- Updates hono demo health endpoint and shutdown handling; refreshes MongoDB connection manager documentation and migration notes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/mongodb/src/lib/mongoConnectionManager.ts | Simplifies manager to single lazy MongoClient, adds close(), updates health check behavior |
| packages/mongodb/src/lib/mongoConnectionManager.test.ts | Adds tests for singleton behavior, connection sharing, retries, and closing |
| examples/hono-demo/src/shared/shell/mongodb.ts | Updates demo wiring to new flattened getInstance options (no cleanup interval) |
| examples/hono-demo/src/shared/shell/http.ts | Health endpoint now reports MongoDB health and returns 503 on DB error |
| examples/hono-demo/src/seedCollections.ts | Ensures the seed script closes MongoDB client on success/failure |
| examples/hono-demo/src/main.ts | Adds SIGTERM/SIGINT shutdown handler to close MongoDB connection |
| docs/guide/mongodb/connection-manager.md | Updates docs to new API, removes cleanup guidance, adds migration notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.