fix(api): drop callback param from handlers for Node.js 24 runtime#28
Merged
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR updates the @overlap/serverless-tools-api package to align handler typing/usage with AWS Lambda’s Node.js 24 runtime by removing the legacy callback-style handler shape, alongside related TypeScript/package metadata changes and dependency bumps.
Changes:
- Remove callback-style handler typing by redefining
HttpApiEventHandleras a 2-arg async function and updatinggetApiHandlerto call controllers without a callback. - Update the API package TypeScript module settings (CommonJS → ESNext) for compilation.
- Bump AWS SDK dependencies in the workspace and disable Nx analytics.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/api/tsconfig.json | Switch API package TS output to ESNext + bundler resolution. |
| packages/api/src/lib/types/apiGateway.ts | Redefine handler type to exclude callback parameter. |
| packages/api/src/lib/apiHandler/apiHandler.ts | Update handler/controller types and invocation to drop callback. |
| packages/api/package.json | Add main/types entrypoints for the package. |
| package.json | Bump AWS SDK dependency versions. |
| package-lock.json | Lockfile updates for dependency bumps (incl. transitive updates). |
| nx.json | Disable Nx analytics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+5
| "module": "esnext", | ||
| "moduleResolution": "bundler", |
Comment on lines
+5
to
+6
| "main": "./src/index.js", | ||
| "types": "./src/index.d.ts", |
Contributor
Author
|
@dgoerdes ist das der sauberste weg? ich bin selber nicht sicher in dem ganzen |
dgoerdes
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.