Skip to content

fix(api): drop callback param from handlers for Node.js 24 runtime#28

Merged
v4ll3l1 merged 2 commits into
mainfrom
fix/fixes-middy-aws-for-node24
Apr 29, 2026
Merged

fix(api): drop callback param from handlers for Node.js 24 runtime#28
v4ll3l1 merged 2 commits into
mainfrom
fix/fixes-middy-aws-for-node24

Conversation

@v4ll3l1
Copy link
Copy Markdown
Contributor

@v4ll3l1 v4ll3l1 commented Apr 28, 2026

No description provided.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @overlap/serverless-tools-api package to align handler typing/usage with AWS Lambda’s Node.js 24 runtime by removing the legacy callback-style handler shape, alongside related TypeScript/package metadata changes and dependency bumps.

Changes:

  • Remove callback-style handler typing by redefining HttpApiEventHandler as a 2-arg async function and updating getApiHandler to call controllers without a callback.
  • Update the API package TypeScript module settings (CommonJS → ESNext) for compilation.
  • Bump AWS SDK dependencies in the workspace and disable Nx analytics.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/api/tsconfig.json Switch API package TS output to ESNext + bundler resolution.
packages/api/src/lib/types/apiGateway.ts Redefine handler type to exclude callback parameter.
packages/api/src/lib/apiHandler/apiHandler.ts Update handler/controller types and invocation to drop callback.
packages/api/package.json Add main/types entrypoints for the package.
package.json Bump AWS SDK dependency versions.
package-lock.json Lockfile updates for dependency bumps (incl. transitive updates).
nx.json Disable Nx analytics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +4 to +5
"module": "esnext",
"moduleResolution": "bundler",
Comment thread packages/api/package.json
Comment on lines +5 to +6
"main": "./src/index.js",
"types": "./src/index.d.ts",
@v4ll3l1
Copy link
Copy Markdown
Contributor Author

v4ll3l1 commented Apr 28, 2026

@dgoerdes ist das der sauberste weg? ich bin selber nicht sicher in dem ganzen

@v4ll3l1 v4ll3l1 requested a review from dgoerdes April 28, 2026 14:24
@v4ll3l1 v4ll3l1 merged commit 0ecebf9 into main Apr 29, 2026
5 checks passed
@v4ll3l1 v4ll3l1 deleted the fix/fixes-middy-aws-for-node24 branch April 29, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants