Skip to content

Replace static oauth state token with random generated #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Replace static oauth state token with random generated #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cmd/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ import (
"nhooyr.io/websocket/wspb"
)

// The value here doesn't matter as long as the server can send it back to us
const oAuthStateString = "98723nd98273d28ydg279"

// requestCmd represents the start command
var requestCmd = &cobra.Command{
Use: "request",
Expand Down Expand Up @@ -103,6 +100,8 @@ func Request(signals chan os.Signal, ready chan bool) int {
}

tokenChan := make(chan *oauth2.Token, 1)
// create a random token for this exchange
oAuthStateString := uuid.New().String()

// Start the web server to listen for the callback
handler := func(w http.ResponseWriter, r *http.Request) {
Expand Down