Implement manual-change subcommand #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Contributor
Author
|
All those alerts would be fixed by github/codeql#13835 |
dylanratcliffe
approved these changes
Aug 21, 2023
Member
dylanratcliffe
left a comment
dylanratcliffe
left a comment
There was a problem hiding this comment.
Approved but with one comment
| // fall through from all "final" query states, check if there's still queries in progress; | ||
| // only break from the loop if all queries have already been sent | ||
| // TODO: see above, still needs DefaultStartTimeout implemented to account for slow sources | ||
| allDone := allDone(ctx, activeQueries, lf) |
Member
There was a problem hiding this comment.
Realistically this check shouldn't be required as the gateway shouldn't tell us we're done unless everything is done right? Can we change maybe the "all responders done, with unfinished queries" log to an error so it's easier to spot? Ideally if this every happens we'd know about it
Contributor
Author
There was a problem hiding this comment.
allDone has a Debugf("query still active") for exactly that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.