Skip to content

(maint) use a centralized .golangci.yml #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024
Merged

(maint) use a centralized .golangci.yml #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ jobs:
- name: Go Init
uses: ./.github/actions/go_init

# get .golangci.yml from github.com/overmindtech/golangci-lint_config
- name: Get .golangci.yml from github.com/overmindtech/golangci-lint_configs
run: |
curl -sfL https://raw.githubusercontent.com/overmindtech/golangci-lint_config/main/.golangci.yml -o .golangci.yml

- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
Expand Down
3 changes: 0 additions & 3 deletions .golangci.yml
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions cmd/auth_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,23 +34,23 @@ func AuthenticatedBookmarkClient(ctx context.Context, oi OvermindInstance) sdpco
return sdpconnect.NewBookmarksServiceClient(httpClient, oi.ApiUrl.String())
}

// AuthenticatedChangesClient Returns a bookmark client that uses the auth
// AuthenticatedChangesClient Returns a changes client that uses the auth
// embedded in the context and otel instrumentation
func AuthenticatedChangesClient(ctx context.Context, oi OvermindInstance) sdpconnect.ChangesServiceClient {
httpClient := NewAuthenticatedClient(ctx, otelhttp.DefaultClient)
log.WithContext(ctx).WithField("apiUrl", oi.ApiUrl).Debug("Connecting to overmind changes API")
return sdpconnect.NewChangesServiceClient(httpClient, oi.ApiUrl.String())
}

// AuthenticatedConfigurationClient Returns a bookmark client that uses the auth
// AuthenticatedConfigurationClient Returns a config client that uses the auth
// embedded in the context and otel instrumentation
func AuthenticatedConfigurationClient(ctx context.Context, oi OvermindInstance) sdpconnect.ConfigurationServiceClient {
httpClient := NewAuthenticatedClient(ctx, otelhttp.DefaultClient)
log.WithContext(ctx).WithField("apiUrl", oi.ApiUrl).Debug("Connecting to overmind configuration API")
return sdpconnect.NewConfigurationServiceClient(httpClient, oi.ApiUrl.String())
}

// AuthenticatedManagementClient Returns a bookmark client that uses the auth
// AuthenticatedManagementClient Returns a management client that uses the auth
// embedded in the context and otel instrumentation
func AuthenticatedManagementClient(ctx context.Context, oi OvermindInstance) sdpconnect.ManagementServiceClient {
httpClient := NewAuthenticatedClient(ctx, otelhttp.DefaultClient)
Expand Down