Fix typos and improve naming conventions across navigation components#8
Merged
aromanov91 merged 5 commits intomainfrom Jun 30, 2025
Merged
Conversation
Co-authored-by: aromanov91 <8157385+aromanov91@users.noreply.github.com>
Co-authored-by: aromanov91 <8157385+aromanov91@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix typos and improve naming conventions
Fix typos and improve naming conventions across navigation components
Jun 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes typos and improves naming conventions across several navigation components while ensuring backward compatibility.
- Corrects spelling errors in struct and method names
- Renames methods and variables to follow Swift naming best practices
- Updates file headers to reference the correct file names
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/OversizeNavigation/ViewModifier/NavigationBarStyle.swift | Corrected struct and method names for proper spelling and consistency |
| Sources/OversizeNavigation/NavigationListLayout/NavigationListLayoutView.swift | Renamed methods and variables; updated file header comments |
| Sources/OversizeNavigation/NavigationLayout/NavigationLayoutView.swift | Renamed methods and variables; updated file header comments |
| Sources/OversizeNavigation/NavigationCoverLayout/NavigationCoverLayoutView.swift | Renamed methods and variables; updated file header comments |
Contributor
|
@copilot Please, check again repo to make sure there are no typos. |
Co-authored-by: aromanov91 <8157385+aromanov91@users.noreply.github.com>
Contributor
Author
I've completed a thorough review of the repository and found several additional typos that have now been fixed (commit 2fecdd8): File header typos fixed:
Code content typo fixed:
All typos across the navigation components have been identified and corrected. |
aromanov91
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses several typos and naming inconsistencies found in the codebase to improve code quality and maintainability while maintaining full backward compatibility.
Changes Made
🔧 Critical Typos Fixed
NavigationBarAppearence→NavigationBarAppearancenaviagtionBarAppearenceConfiguration()→navigationBarAppearanceConfiguration()📄 File Comments Corrected
Updated copyright headers in navigation layout files to reference correct file names:
NavigationLayoutView.swift(was incorrectly "PageView.swift")NavigationListLayoutView.swift(was incorrectly "PageView.swift")NavigationCoverLayoutView.swift(was incorrectly "PageView.swift")🏷️ Improved Naming Conventions
Following Swift naming best practices, renamed methods and variables across all navigation components:
Methods:
onTapBackButton()→handleBackButtonTap()onTapConfirmationBack()→handleConfirmationBackTap()onTapConfirmationCancel()→handleConfirmationCancelTap()Variables:
isPresentBackConfirmation→isBackConfirmationPresented🔄 Backward Compatibility Maintained
All deprecated methods are preserved with
@available(*, deprecated, renamed: "newName")annotations:Files Updated
Sources/OversizeNavigation/ViewModifier/NavigationBarStyle.swiftSources/OversizeNavigation/NavigationLayout/NavigationLayoutView.swiftSources/OversizeNavigation/NavigationListLayout/NavigationListLayoutView.swiftSources/OversizeNavigation/NavigationCoverLayout/NavigationCoverLayoutView.swiftImpact
Testing
The changes maintain the exact same functionality while improving code quality. All deprecated methods delegate to their new implementations, ensuring seamless backward compatibility.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.