Skip to content

Fix typos and improve naming conventions across navigation components#8

Merged
aromanov91 merged 5 commits intomainfrom
copilot/fix-73ab9d90-1e1b-4a40-8d10-a108cd06f1dc
Jun 30, 2025
Merged

Fix typos and improve naming conventions across navigation components#8
aromanov91 merged 5 commits intomainfrom
copilot/fix-73ab9d90-1e1b-4a40-8d10-a108cd06f1dc

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 30, 2025

Overview

This PR addresses several typos and naming inconsistencies found in the codebase to improve code quality and maintainability while maintaining full backward compatibility.

Changes Made

🔧 Critical Typos Fixed

  • Struct name: NavigationBarAppearenceNavigationBarAppearance
  • Method name: naviagtionBarAppearenceConfiguration()navigationBarAppearanceConfiguration()

📄 File Comments Corrected

Updated copyright headers in navigation layout files to reference correct file names:

  • NavigationLayoutView.swift (was incorrectly "PageView.swift")
  • NavigationListLayoutView.swift (was incorrectly "PageView.swift")
  • NavigationCoverLayoutView.swift (was incorrectly "PageView.swift")

🏷️ Improved Naming Conventions

Following Swift naming best practices, renamed methods and variables across all navigation components:

Methods:

  • onTapBackButton()handleBackButtonTap()
  • onTapConfirmationBack()handleConfirmationBackTap()
  • onTapConfirmationCancel()handleConfirmationCancelTap()

Variables:

  • isPresentBackConfirmationisBackConfirmationPresented

🔄 Backward Compatibility Maintained

All deprecated methods are preserved with @available(*, deprecated, renamed: "newName") annotations:

@available(*, deprecated, renamed: "handleBackButtonTap")
private func onTapBackButton() {
    handleBackButtonTap()
}

Files Updated

  • Sources/OversizeNavigation/ViewModifier/NavigationBarStyle.swift
  • Sources/OversizeNavigation/NavigationLayout/NavigationLayoutView.swift
  • Sources/OversizeNavigation/NavigationListLayout/NavigationListLayoutView.swift
  • Sources/OversizeNavigation/NavigationCoverLayout/NavigationCoverLayoutView.swift

Impact

  • No breaking changes - existing code continues to work with deprecation warnings
  • Improved code readability with better naming conventions
  • Fixed critical typos that could cause confusion
  • Consistent documentation with correct file references
  • Better Swift compliance following naming best practices

Testing

The changes maintain the exact same functionality while improving code quality. All deprecated methods delegate to their new implementations, ensuring seamless backward compatibility.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits June 30, 2025 12:51
Co-authored-by: aromanov91 <8157385+aromanov91@users.noreply.github.com>
Co-authored-by: aromanov91 <8157385+aromanov91@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix typos and improve naming conventions Fix typos and improve naming conventions across navigation components Jun 30, 2025
Copilot AI requested a review from aromanov91 June 30, 2025 12:55
@aromanov91 aromanov91 marked this pull request as ready for review June 30, 2025 13:22
Copilot AI review requested due to automatic review settings June 30, 2025 13:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes typos and improves naming conventions across several navigation components while ensuring backward compatibility.

  • Corrects spelling errors in struct and method names
  • Renames methods and variables to follow Swift naming best practices
  • Updates file headers to reference the correct file names

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Sources/OversizeNavigation/ViewModifier/NavigationBarStyle.swift Corrected struct and method names for proper spelling and consistency
Sources/OversizeNavigation/NavigationListLayout/NavigationListLayoutView.swift Renamed methods and variables; updated file header comments
Sources/OversizeNavigation/NavigationLayout/NavigationLayoutView.swift Renamed methods and variables; updated file header comments
Sources/OversizeNavigation/NavigationCoverLayout/NavigationCoverLayoutView.swift Renamed methods and variables; updated file header comments

@aromanov91
Copy link
Copy Markdown
Contributor

@copilot Please, check again repo to make sure there are no typos.

Co-authored-by: aromanov91 <8157385+aromanov91@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jun 30, 2025

@copilot Please, check again repo to make sure there are no typos.

I've completed a thorough review of the repository and found several additional typos that have now been fixed (commit 2fecdd8):

File header typos fixed:

  • NavigationBarStyle.swift: "NavigationBarAppearenceColor.swift" → "NavigationBarStyle.swift"
  • AlertResolve.swift: "AlertRouter.swift" → "AlertResolve.swift"
  • NavigationLayoutViewModifier.swift: "NavigationPageViewModifier.swift" → "NavigationLayoutViewModifier.swift"
  • NavigationListLayoutViewModifier.swift: "NavigationPageViewModifier.swift" → "NavigationListLayoutViewModifier.swift"
  • NavigationCoverLayoutViewModifier.swift: "NavigationCoverPageViewModifier.swift" → "NavigationCoverLayoutViewModifier.swift"
  • NavigationSendValueModifier.swift & NavigationDestinationModifier.swift: Both incorrectly had "NavigationDestinationValueModifier.swift"

Code content typo fixed:

  • AlertResolve.swift: Fixed "default`" → "default" (removed extra backtick)

All typos across the navigation components have been identified and corrected.

@aromanov91 aromanov91 merged commit 3eb18fd into main Jun 30, 2025
2 checks passed
@aromanov91 aromanov91 deleted the copilot/fix-73ab9d90-1e1b-4a40-8d10-a108cd06f1dc branch June 30, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants