Skip to content

fix:octane模式下导出metric #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix:octane模式下导出metric #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Facades/Metric.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* @method static \OpenTelemetry\API\Metrics\HistogramInterface histogram(string $name, ?string $unit = null, ?string $description = null, array $advisories = [])
* @method static \OpenTelemetry\API\Metrics\GaugeInterface gauge(string $name, ?string $unit = null, ?string $description = null, array $advisories = [])
* @method static \OpenTelemetry\API\Metrics\ObservableGaugeInterface observableGauge(string $name, ?string $unit = null, ?string $description = null, array|callable $advisories = [], callable ...$callbacks)
* @method static void flush()
*
* @see \Overtrue\LaravelOpenTelemetry\Support\Metric
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Handlers/RequestTerminatedHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

use Laravel\Octane\Events\RequestTerminated;
use Overtrue\LaravelOpenTelemetry\Facades\Measure;
use Overtrue\LaravelOpenTelemetry\Facades\Metric;

class RequestTerminatedHandler
{
Expand All @@ -16,5 +17,6 @@ public function handle(RequestTerminated $event): void
{
// In Octane mode, we need to force flush the tracer provider.
Measure::flush();
Metric::flush();
}
}
9 changes: 9 additions & 0 deletions src/Support/Metric.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Illuminate\Contracts\Foundation\Application;
use Illuminate\Support\Facades\Log;
use OpenTelemetry\API\Globals;
use OpenTelemetry\API\Metrics\CounterInterface;
use OpenTelemetry\API\Metrics\GaugeInterface;
use OpenTelemetry\API\Metrics\HistogramInterface;
Expand Down Expand Up @@ -39,6 +40,14 @@ public function isEnabled(): bool
return self::$enabled;
}

/**
* Force flush (for Octane mode)
*/
public function flush(): void
{
Globals::meterProvider()?->forceFlush();
}

// ======================= Core OpenTelemetry API =======================

/**
Expand Down