fix:自定义meterProvider #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overtrue
reviewed
Sep 25, 2025
src/OpenTelemetryServiceProvider.php
Outdated
| return Globals::meterProvider() | ||
| ->getMeter(config('otel.meter_name', 'overtrue.laravel-open-telemetry')); | ||
| $resourceInfo = (new Sdk)->getResource(); | ||
| Metric::$meterProvider = (new MeterProviderFactory)->create($resourceInfo); |
Owner
There was a problem hiding this comment.
可以考虑给 Metric 增加一个 Setter 和 Getter 方法，把属性私有，这么直接改感觉不太好
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
自定义meterProvider，因为默认的provider中会携带service.instance.id属性，上报到prometheus的时候会自动转换为instance属性，为了避免instance属性被覆盖，所以使用自定义的meterProvider