🐛 136 - test routing fix #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blabadi
reviewed
Mar 17, 2021
Dockerfile
Outdated
| ENV REACT_APP_EGO_CLIENT_ID=ego | ||
| ENV REACT_APP_API=http://localhost:8081/ | ||
| ENV PUBLIC_URL="/" | ||
| ARG REACT_APP_PUBLIC_URL="/" |
There was a problem hiding this comment.
what is the need for an ARG ? these are for docker build command
Contributor
Author
There was a problem hiding this comment.
i had the same setup in dms-ui, i thought that was needed. But can change it back if not!
Dockerfile
Outdated
| ENV PUBLIC_URL="/" | ||
| ARG REACT_APP_PUBLIC_URL="/" | ||
|
|
||
| ENV REACT_APP_PUBLIC_URL ${REACT_APP_PUBLIC_URL} |
There was a problem hiding this comment.
this could be ENV REACT_APP_PUBLIC_URL="/"
blabadi
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.