Skip to content

💄 126 - Hide facebook login #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2021
Merged

💄 126 - Hide facebook login #139

merged 2 commits into from
Mar 18, 2021

Conversation

@anncatton
Copy link
Contributor

@anncatton anncatton commented Mar 17, 2021

Hide facebook login until ego-555 is implemented

joneubank
joneubank requested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@joneubank joneubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should just comment out the facebook entry from the providers array with a note explaining why we are temporarily (for now) disabling it.

Long term, the list of providers should be configurable through .env properties so that any implementers can control which providers are enabled on their own instance of the ego ui.

@anncatton
Copy link
Contributor Author

anncatton commented Mar 18, 2021

Perhaps we should just comment out the facebook entry from the providers array with a note explaining why we are temporarily (for now) disabling it.

Long term, the list of providers should be configurable through .env properties so that any implementers can control which providers are enabled on their own instance of the ego ui.

Making these configurable is part of the roadmap for Canarie, we have a ticket open #140

ciaranschutte
ciaranschutte previously approved these changes Mar 18, 2021
View reviewed changes
@ciaranschutte
Copy link

ciaranschutte commented Mar 18, 2021

@anncatton missed Jons comment above, ignore my approval :p

@anncatton anncatton requested a review from joneubank March 18, 2021 19:19
@anncatton anncatton merged commit 8d8c438 into develop Mar 18, 2021
@anncatton anncatton deleted the 126-hide-facebook branch March 18, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joneubank joneubank joneubank approved these changes

@ciaranschutte ciaranschutte ciaranschutte left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anncatton @ciaranschutte @joneubank