Move data validation functions into shared module#212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation functionality provided by the Lectern Client is moved into its own module. This module is added at the path
libraries/validationand will be published as@overture-stack/lectern-validation.This module exports all logic for validating data record value types and all restrictions as defined in the current Lectern Dictionary. The validation pipelines and processing functions remain in the client for now as these will likely require refactoring along with the conditional restriction work. No sense to refactor them to support generalization when we will only tear them apart in a short time.
Changes