Skip to content

Move data validation functions into shared module#212

Merged
joneubank merged 8 commits intodevelopfrom
feat/standalone-validation
Jun 15, 2024
Merged

Move data validation functions into shared module#212
joneubank merged 8 commits intodevelopfrom
feat/standalone-validation

Conversation

@joneubank
Copy link
Copy Markdown
Contributor

@joneubank joneubank commented Jun 15, 2024

Validation functionality provided by the Lectern Client is moved into its own module. This module is added at the path libraries/validation and will be published as @overture-stack/lectern-validation.

This module exports all logic for validating data record value types and all restrictions as defined in the current Lectern Dictionary. The validation pipelines and processing functions remain in the client for now as these will likely require refactoring along with the conditional restriction work. No sense to refactor them to support generalization when we will only tear them apart in a short time.

Changes

  • Creation of Validation module
  • Moving all validation functions out of client and into shared validation module
    • data type validations
    • restriction validations (dictionary and schema level)
  • Client processing code relies on validation module

@joneubank joneubank marked this pull request as ready for review June 15, 2024 17:18
@joneubank joneubank merged commit c783f64 into develop Jun 15, 2024
@joneubank joneubank deleted the feat/standalone-validation branch June 15, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant