nether biomes #1812
nether biomes #1812
Conversation
|
@CounterPillow I would like to go on with logs, slabs and stairs, as soon as thus is merged. |
CounterPillow
left a comment
CounterPillow
left a comment
There was a problem hiding this comment.
Looks mostly okay aside from the large if-ery in the wood blocks, which I'd appreciate if you replaced into a dictionary lookup for easier future maintenance and less branching
| if blockid == 1008: # nether logs aka stem | ||
| if wood_type == 0: # warped_stem | ||
| top = self.load_image_texture("assets/minecraft/textures/block/warped_stem_top.png") | ||
| side = self.load_image_texture("assets/minecraft/textures/block/warped_stem.png") | ||
| if wood_type == 1: # stripped_warped_stem | ||
| top = self.load_image_texture("assets/minecraft/textures/block/warped_stem_top.png") | ||
| side = self.load_image_texture("assets/minecraft/textures/block/stripped_warped_stem.png") | ||
| if wood_type == 2: # crimson_stem | ||
| top = self.load_image_texture("assets/minecraft/textures/block/crimson_stem_top.png") | ||
| side = self.load_image_texture("assets/minecraft/textures/block/crimson_stem.png") | ||
| if wood_type == 3: # crimson_stem | ||
| top = self.load_image_texture("assets/minecraft/textures/block/crimson_stem_top.png") | ||
| side = self.load_image_texture("assets/minecraft/textures/block/stripped_crimson_stem.png") | ||
| if blockid == 1009: # nether hyphae | ||
| if wood_type == 0: # warped_hyphae | ||
| top = self.load_image_texture("assets/minecraft/textures/block/warped_stem.png") | ||
| side = top | ||
| if wood_type == 1: # stripped_warped_hyphae | ||
| top = self.load_image_texture("assets/minecraft/textures/block/stripped_warped_stem.png") | ||
| side = top | ||
| if wood_type == 2: # crimson_hyphae | ||
| top = self.load_image_texture("assets/minecraft/textures/block/crimson_stem.png") | ||
| side = top | ||
| if wood_type == 3: # stripped_crimson_hyphae | ||
| top = self.load_image_texture("assets/minecraft/textures/block/stripped_crimson_stem.png") | ||
| side = top |
There was a problem hiding this comment.
these ifs only ever end up taking one branch, so checking all the others with further "if" conditions as opposed to elif is checking way more than it should for no reason. Ideally this would all just be refactored into a dictionary lookup though.
| # 1 UNWSE | ||
| # 2 UWSEN | ||
| # 3 USENW | ||
|
|
There was a problem hiding this comment.
extraneous whitespace added
IncredibleHolg
force-pushed
the
my-116-blocks
branch
from
5a74291 to
0a9d196
Compare
| soul_soil_texture="assets/minecraft/textures/block/soul_soil.png" | ||
| block(blockid=1020, top_image=soul_soil_texture, side_image=soul_soil_texture) | ||
| # nether gold ore | ||
| nether_gold_texture="assets/minecraft/textures/block/nether_gold_ore.png" | ||
| block(blockid=1021, top_image=nether_gold_texture, side_image=nether_gold_texture) |
There was a problem hiding this comment.
There's no need to specify the same image as both top_image and side_image, if side_image is missing, then it takes on the value of top_image.
|
If you'd prefer I can merge this right now and fix the various nitpicks I had with a followup commit |
2 participants
All blocks needed for the warped and cromson biomes are now implemented.